This repository was archived by the owner on Mar 9, 2019. It is now read-only.
Better error message#7
Open
6twenty wants to merge 1 commit intobeatrichartz:masterfrom
6twenty:better-error
Open
Better error message#76twenty wants to merge 1 commit intobeatrichartz:masterfrom 6twenty:better-error
6twenty wants to merge 1 commit intobeatrichartz:masterfrom
6twenty:better-error
Conversation
Ensures that the error raised contains the `from` and `to` currency codes.
|
+1 |
Owner
|
I will put some work into this in the next days in order to provide a patch. Thanks for raising the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures that the error raised contains the
fromandtocurrency codes.Prior to this change, the error raised would not contain the from & to currency codes, eg:
Exchange::NoRateError: No rates where found for to 1.380024 at Sun Aug 01 00:00:00 +1200 2010This is because the method only raises an error when
from_codeandto_codearenil. This is an perfectly fine way to raise the error, but it also means that thosenilvalues are getting used in the error message string. This commit supplies the original from & to codes as well, so they they may be used in the error message.This is a fairly ugly and direct way to fix this issue, so feel free to take it or leave it -- but please do add the currency codes to the error message one way or another.