Skip to content

feat: add two half pass approach to beam potential#619

Merged
davidrudlstorfer merged 1 commit intobeamme-py:mainfrom
davidrudlstorfer:add_two_half_pass_approach
Apr 13, 2026
Merged

feat: add two half pass approach to beam potential#619
davidrudlstorfer merged 1 commit intobeamme-py:mainfrom
davidrudlstorfer:add_two_half_pass_approach

Conversation

@davidrudlstorfer
Copy link
Copy Markdown
Collaborator

FYI: test pipeline does not fail because we do not write out the file during testing (the validation happens during the write), but the pre-commit hook where we verify the input file fails

Follows 4C-multiphysics/4C#1957

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for 4C’s “two half pass” approach configuration to BeamMe’s beam potential input generation, aligning generated YAML with upstream 4C expectations (per referenced 4C PR).

Changes:

  • Extend BeamPotential.create_header() to include a two_half_pass option and emit it into the beam_potential header dict.
  • Update the beam potential integration test to pass two_half_pass=True.
  • Update the corresponding reference YAML file to include two_half_pass: true.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/beamme/four_c/beam_potential.py Adds two_half_pass argument + writes it into the generated beam_potential header.
tests/integration/test_integration_four_c_beam_potential.py Passes two_half_pass=True when constructing the beam potential header in the integration test.
tests/reference-files/test_integration_four_c_beam_potential_helix.4C.yaml Updates expected YAML output to include two_half_pass: true.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/beamme/four_c/beam_potential.py
@davidrudlstorfer davidrudlstorfer temporarily deployed to cubit_secrets_trusted April 9, 2026 14:39 — with GitHub Actions Inactive
@davidrudlstorfer
Copy link
Copy Markdown
Collaborator Author

pipeline now succeeds because the changes are in fourcipp

@davidrudlstorfer davidrudlstorfer merged commit 5348778 into beamme-py:main Apr 13, 2026
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants