feat: add two half pass approach to beam potential#619
Merged
davidrudlstorfer merged 1 commit intobeamme-py:mainfrom Apr 13, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for 4C’s “two half pass” approach configuration to BeamMe’s beam potential input generation, aligning generated YAML with upstream 4C expectations (per referenced 4C PR).
Changes:
- Extend
BeamPotential.create_header()to include atwo_half_passoption and emit it into thebeam_potentialheader dict. - Update the beam potential integration test to pass
two_half_pass=True. - Update the corresponding reference YAML file to include
two_half_pass: true.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/beamme/four_c/beam_potential.py |
Adds two_half_pass argument + writes it into the generated beam_potential header. |
tests/integration/test_integration_four_c_beam_potential.py |
Passes two_half_pass=True when constructing the beam potential header in the integration test. |
tests/reference-files/test_integration_four_c_beam_potential_helix.4C.yaml |
Updates expected YAML output to include two_half_pass: true. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
isteinbrecher
approved these changes
Apr 10, 2026
Collaborator
Author
|
pipeline now succeeds because the changes are in fourcipp |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FYI: test pipeline does not fail because we do not write out the file during testing (the validation happens during the write), but the pre-commit hook where we verify the input file fails
Follows 4C-multiphysics/4C#1957