Fix CLI overriding Dockerfile BEAM_DOTNET_VERSION with hardcoded alpine tag#4539
Fix CLI overriding Dockerfile BEAM_DOTNET_VERSION with hardcoded alpine tag#4539
Conversation
…ld command Co-authored-by: cdhanna <3848374+cdhanna@users.noreply.github.com>
…e casing Co-authored-by: cdhanna <3848374+cdhanna@users.noreply.github.com>
…RSION Co-authored-by: cdhanna <3848374+cdhanna@users.noreply.github.com>
|
@docnerd, doc for core/v7.1 |
|
I am docNerd. yes, working on it. Watch the workflow |
|
I am docNerd. I reviewed the PR but didn't find documentation changes that needed to be made. |
|
@docnerd, doc for core/v7.1 |
|
I am docNerd. yes, working on it. Watch the workflow |
|
I am docNerd. I reviewed the PR but didn't find documentation changes that needed to be made. |
|
@docnerd, doc for core/v7.1 |
|
I am docNerd. yes, working on it. Watch the workflow |
|
@docnerd, doc for core/v7.1 |
|
I am docNerd. yes, working on it. Watch the workflow |
|
I am docNerd. I reviewed the PR but didn't find documentation changes that needed to be made. |
|
@docnerd, doc for core/v7.1 |
|
I am docNerd. yes, working on it. Watch the workflow |
|
I am docNerd. Here is the link to the Doc changes: beamable/docs#47 |
|
@docnerd, doc for core/v7.1 |
|
I am docNerd. yes, working on it. Watch the workflow |
|
I am docNerd. Here is the link to the Doc changes: beamable/docs#48 |
|
@docnerd, doc for core/v7.1 |
|
I am docNerd. yes, working on it. Watch the workflow |
|
I am docNerd. Here is the link to the Doc changes: beamable/docs#49 |
|
@docnerd, doc for core/v7.1 |
|
I am docNerd. yes, working on it. Watch the workflow |
|
I am docNerd. I ran into an error generating docs: Error code: 400 - {'type': 'error', 'error': {'type': 'invalid_request_error', 'message': 'input length and |
|
@docnerd, doc for core/v7.1 |
|
I am docNerd. yes, working on it. Watch the workflow |
|
I am also docnerd. :-) This could create confusion, no? |
Ah, many apologies friend. I was not using my brain. I am developing a tool to help capture changes as documentation updates. But yes, I should not have picked an existing user name. |
|
docnerd, doc for core/v7.1 |
|
docNerd, doc for core/v7.1 |
1 similar comment
|
docNerd, doc for core/v7.1 |
|
I am docNerd. yes, working on it. Watch the workflow |
Ticket
https://disruptorbeam.atlassian.net/browse/BEAM-XXXX
Brief Description
CLI always passed
--build-arg BEAM_DOTNET_VERSION=X.0-alpinetodocker buildx build, making it impossible to use non-alpine base images (e.g.noble). The tag was computed solely fromTargetFramework, ignoring user intent.Fix: Read the
ContainerFamilyMSBuild property from the service's.csproj(same pattern asTargetFramework) and combine it with the parsed dotnet version to form the tag.ServicesBuildCommand.csContainerFamilyviamsbuildProject.GetPropertyValue("ContainerFamily")GetDefaultBaseImageTag(targetFramework)withGetBaseImageTag(targetFramework, containerFamily)net10.0→10.0) — no hardcoded version list, forward-compatibleContainerFamilyvalidated against{ "alpine", "noble" }; defaults to"alpine"if absent or unrecognisedUsage: Set
<ContainerFamily>noble</ContainerFamily>in the service.csproj. The CLI will pass--build-arg BEAM_DOTNET_VERSION=10.0-nobleautomatically.Checklist
Notes
When you are merging a feature branch into
main, please squash merge and make sure the final commit contains any relevent JIRA ticket number. If you are merging frommaintostaging, orstagingtoproduction, please use a regular merge commit.Does this introduce tech-debt? If so, have you added an entry to the Tech-debt document?
Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.