-
Notifications
You must be signed in to change notification settings - Fork 3
Improve open api schema population #4443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Leinnan
wants to merge
19
commits into
main
Choose a base branch
from
feature/improveOpenApiSchemaPopulation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
886c6dd
OpenAPI- improve schema generation
Leinnan 2b412c7
Improved OpenAPI components schema gen
Leinnan 7a583ea
Reduce code repetition
Leinnan a8e5a20
Simplify code
Leinnan 81d9cee
Fix code doc
Leinnan d7cdee0
Merge remote-tracking branch 'origin/main' into feature/improveOpenAp…
Leinnan 2c349e0
improvements, more tests
Leinnan 5fbd62d
Improvements, part 2
Leinnan bd542a7
Generate schemas for content references
Leinnan b14634f
Working version
Leinnan 36c1e71
Improve OpenAPI document merging
Leinnan d90ae65
Fix calling `oapi download --combine-into-one-document` when `--outpu…
Leinnan a00a74f
Merge remote-tracking branch 'origin/main' into feature/improveOpenAp…
Leinnan 0a6ced4
Squashed commit of the following:
Leinnan b621cea
Fix compilation
Leinnan 13fe05b
Merge branch 'main' into feature/improveOpenApiSchemaPopulation
Leinnan 5fd6e3f
Update microservice/beamable.tooling.common/OpenAPI/SchemaGenerator.cs
Leinnan f4ce611
Update microservice/beamable.tooling.common/TypeExtensions.cs
Leinnan 9d27738
Update microservice/beamable.tooling.common/OpenAPI/SchemaGenerator.cs
Leinnan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unused variable. The variable 'mergedSchema' is assigned the result of MergeSchemasWithExtensionMerge but is never used. The method modifies the original schema in-place (as seen in the implementation), but the assignment suggests the result should be used. Either remove the assignment or clarify the intent.