This repository was archived by the owner on Dec 25, 2025. It is now read-only.
Use linkToDeath for PackageManager resilience#29
Merged
Conversation
The previous implementation used `pingBinder()` to check the liveness of the PackageManager service on every call to `getPm()`. This polling approach introduces an unnecessary IPC round-trip overhead for every access. This commit refactors the logic to use the canonical, event-driven pattern for handling remote service death by implementing `linkToDeath`. A `DeathRecipient` is now registered with the binder upon the first connection. If the service process (`system_server`) dies for any reason, the `binderDied()` callback is automatically invoked by the system. This callback proactively clears the cached service instance, ensuring that the next call to `getPm()` will transparently re-establish a valid connection.
beakthoven
approved these changes
Aug 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous implementation used
pingBinder()to check the liveness of the PackageManager service on every call togetPm(). This polling approach introduces an unnecessary IPC round-trip overhead for every access.This commit refactors the logic to use the canonical, event-driven pattern for handling remote service death by implementing
linkToDeath.A
DeathRecipientis now registered with the binder upon the first connection. If the service process (system_server) dies for any reason, thebinderDied()callback is automatically invoked by the system. This callback proactively clears the cached service instance, ensuring that the next call togetPm()will transparently re-establish a valid connection.