Skip to content

Refresh background color preview on HSV slider changes and refactor HSVSliderGroup#6

Merged
beackers merged 1 commit intocustomfrom
codex/add-dynamic-background-color-change
Feb 6, 2026
Merged

Refresh background color preview on HSV slider changes and refactor HSVSliderGroup#6
beackers merged 1 commit intocustomfrom
codex/add-dynamic-background-color-change

Conversation

@beackers
Copy link
Owner

@beackers beackers commented Feb 5, 2026

Motivation

  • Make the background color preview in flow_field.xml update live when the bg HSV sliders are moved.
  • Provide a mechanism for grouped slider handlers to receive combined HSV updates.
  • Keep slider bindings flexible so external listeners can react to progress changes.

Description

  • Add a ProgressCallback interface and optional callback support to SliderBinding via a new constructor and setProgressCallback, and invoke it from onProgressChanged in the slider listener.
  • Wire the same callback invocation into LogSliderBinding so logarithmic sliders can also trigger external listeners.
  • Refactor HSVSliderGroup to accept an HSVChangeListener, store individual SliderBinding instances, register per-slider ProgressCallbacks that compute combined HSV with getValue, and call the HSVChangeListener on changes.
  • Update FlowFieldActivity to pass a lambda to HSVSliderGroup that calls a new updateBgColorPreview helper which sets the bgColorPreview background with Color.HSVToColor, and add the necessary import.

Testing

  • No automated tests were run for this change.

Codex Task

@chatgpt-codex-connector
Copy link

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@beackers beackers merged commit 29c5230 into custom Feb 6, 2026
1 check passed
@beackers beackers deleted the codex/add-dynamic-background-color-change branch February 6, 2026 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant