ci: standardize workflows and chart patterns to match org playbook#23
Merged
Conversation
Co-Authored-By: kyle_hunter@bcit.ca <kyle_hunter@bcit.ca>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Standardizes CI/CD workflows and Helm chart patterns to match the org playbook, using
bcit-tlu/qcon-apias the reference implementation.Changes across all workflows:
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: trueto top-levelenv:(was missing frompr-title-lint.yaml,release-please.yaml,helm-publish.yaml,docs.yml)actions/checkouttov6indocs.yml(wasv5)# Cosign keyless (Sigstore OIDC))# ── Sign with Cosign ...)ci.yaml (helm-publish job):
${{ }}expressions fromrun:blocks into step-levelenv:blocks (Cosign login, Helm login, package/push/sign)awk '/^name:/{print $2; exit}'withyq '.name'for chart name extraction|| true+grep -q) with new pattern (|| { echo; exit 1; })helm-publish.yaml:
${{ }}refs intoenv:blockrelease-retag.yaml:
${{ }}expressions intoenv:blocks for highest-check, retag, and sign steps&& steps.retag.outputs.digest != '') to sign step conditionrelease-please.yaml:
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: trueenv blockChart.yaml:
# x-release-please-versionfromversion:line (chart version is hand-maintained per repo convention; onlyappVersion:is managed by release-please)release-please-config.json:
generictype toyamltype withjsonpath: "$.appVersion"to only updateappVersion(matching the hand-maintained chart version convention)deployment.yaml:
{{- if $aff }}to{{- if ne (toJson $aff) "{}" }}for proper empty-map detectionvalues.yaml:
zoneAntiAffinityNew: AGENTS.md
Review & Testing Checklist for Human
release-please-config.jsonchange fromgenerictoyaml+jsonpathcorrectly targets onlyappVersion— this is the most significant semantic change. Confirm that future release-please runs updateappVersionbut leaveversionuntouched.${{ }}expressions remain inrun:blocks for Cosign/Helm login and sign steps across all workflows.docs.ymlworkflow still deploys GitHub Pages correctly after theactions/checkoutbump to v6 and addition of the env block.Notes
build-and-push-app.yaml.inactivefile was not modified since it is inactive.docs.ymlID token permission was already present; only the env block and checkout version were updated.Link to Devin session: https://app.devin.ai/sessions/8fed2b4905fe46529f3030e4818b239a
Requested by: @kphunter