fix: remove stale release-as and fix CLASSPATH undefined var warning#28
Merged
Merged
Conversation
Remove the one-shot release-as override now that v1.6.0 has landed. Drop the self-referencing $CLASSPATH prefix in the Dockerfile ENV since it is undefined at that point, triggering a Docker build warning. Co-Authored-By: kyle_hunter@bcit.ca <kyle_hunter@bcit.ca>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two cleanup fixes:
Remove
release-as: "1.6.0"fromrelease-please-config.json— v1.6.0 has been released, so the one-shot override must be removed to prevent the staleness guard from blocking future releases. Future versions will bump normally from the manifest (now at 1.6.0).Fix
$CLASSPATHundefined variable warning inDockerfileline 12 —ENV CLASSPATH=$CLASSPATH:...referenced$CLASSPATHbefore it was defined, producing a Docker build warning (UndefinedVar). Removed the self-referencing prefix since no priorCLASSPATHvalue exists in the base image.Review & Testing Checklist for Human
Risk: 🟢 Low
UndefinedVarwarning for$CLASSPATHfeat:/fix:merge (no longer stuck on 1.6.0)Notes
CLASSPATHchange is safe because thepython:3.11-slimbase image does not setCLASSPATH, so the self-reference always resolved to an empty string (producing a leading:in the path). Removing it produces a cleaner value.Link to Devin session: https://app.devin.ai/sessions/c8038ad2684a4fd786c6aa2a07ce9425
Requested by: @kphunter