Skip to content

fix: remove stale release-as and fix CLASSPATH undefined var warning#28

Merged
kphunter merged 1 commit into
mainfrom
devin/1779681861-post-release-cleanup
May 25, 2026
Merged

fix: remove stale release-as and fix CLASSPATH undefined var warning#28
kphunter merged 1 commit into
mainfrom
devin/1779681861-post-release-cleanup

Conversation

@devin-ai-integration

Copy link
Copy Markdown
Contributor

Summary

Two cleanup fixes:

  1. Remove release-as: "1.6.0" from release-please-config.json — v1.6.0 has been released, so the one-shot override must be removed to prevent the staleness guard from blocking future releases. Future versions will bump normally from the manifest (now at 1.6.0).

  2. Fix $CLASSPATH undefined variable warning in Dockerfile line 12 — ENV CLASSPATH=$CLASSPATH:... referenced $CLASSPATH before it was defined, producing a Docker build warning (UndefinedVar). Removed the self-referencing prefix since no prior CLASSPATH value exists in the base image.

Review & Testing Checklist for Human

Risk: 🟢 Low

  • Verify the Docker build no longer shows the UndefinedVar warning for $CLASSPATH
  • Verify release-please creates normal version bumps on the next feat:/fix: merge (no longer stuck on 1.6.0)

Notes

  • The CLASSPATH change is safe because the python:3.11-slim base image does not set CLASSPATH, so the self-reference always resolved to an empty string (producing a leading : in the path). Removing it produces a cleaner value.

Link to Devin session: https://app.devin.ai/sessions/c8038ad2684a4fd786c6aa2a07ce9425
Requested by: @kphunter

Remove the one-shot release-as override now that v1.6.0 has landed.
Drop the self-referencing $CLASSPATH prefix in the Dockerfile ENV
since it is undefined at that point, triggering a Docker build warning.

Co-Authored-By: kyle_hunter@bcit.ca <kyle_hunter@bcit.ca>
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@kphunter kphunter merged commit 40b3105 into main May 25, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant