fix: exclude charts/templates/secrets.yaml from secrets gitignore#26
Merged
Conversation
The **/secrets* pattern catches the Helm chart secrets template, requiring force-add on every change. Add a negation so the chart template is tracked normally. Co-Authored-By: kyle_hunter@bcit.ca <kyle_hunter@bcit.ca>
devin-ai-integration
Bot
requested review from
arolos,
kphunter and
visoedhwa
as code owners
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
**/secrets*gitignore pattern catchescharts/templates/secrets.yaml, requiringgit add -fon every change. This adds a negation rule so the Helm chart secrets template is tracked normally.This also serves as the user-facing commit needed for release-please to create the v1.6.0 release PR — the
release-as: "1.6.0"config (PR #25) requires at least onefix:/feat:commit since the last release (v0.3.0) to trigger.Review & Testing Checklist for Human
Risk: 🟢 Low (gitignore-only change)
charts/templates/secrets.yamlshows as tracked (not ignored) after this changeNotes
release-asmust be removed fromrelease-please-config.jsonin a follow-up PR.Link to Devin session: https://app.devin.ai/sessions/c8038ad2684a4fd786c6aa2a07ce9425
Requested by: @kphunter