Skip to content

ci: standardize workflows and chart patterns to match org playbook#18

Merged
kphunter merged 1 commit into
mainfrom
devin/1779662876-standardize-patterns
May 25, 2026
Merged

ci: standardize workflows and chart patterns to match org playbook#18
kphunter merged 1 commit into
mainfrom
devin/1779662876-standardize-patterns

Conversation

@devin-ai-integration

Copy link
Copy Markdown
Contributor

Summary

Aligns conversion-guide CI/CD workflows and documentation with the qcon-api reference implementation:

  • AGENTS.md: Restructured to match qcon-api format — added Architecture, Development Workflow sections; expanded CI/CD section with details about FORCE_JAVASCRIPT_ACTIONS_TO_NODE24, OCI image/chart registry paths, and release-please annotations; updated Project Structure to use /path — description format with /.github/workflows/ entry
  • release-retag.yaml: Quoted all $GITHUB_OUTPUT references for shell safety; renamed TAGSTAG_ARGS variable to match qcon-api convention

All other standardization items (checkout@v6, FORCE_JAVASCRIPT_ACTIONS_TO_NODE24, helm push error guard, tolerant digest parse, yq chart name extraction, shell-safe GHA env blocks, digest guard on sign steps, Chart.yaml annotations, release-please-config.json, affinity conditional) were already applied in a prior PR.

Review & Testing Checklist for Human

  • Verify AGENTS.md Architecture section accurately describes the conversion-guide app (nginx-unprivileged on 8080, Gulp build pipeline, Plausible analytics)
  • Confirm release-retag.yaml TAG_ARGS rename doesn't conflict with any external references

Notes

Helm lint and kubeconform validation both pass locally. No functional workflow changes — only documentation and shell quoting improvements.

Link to Devin session: https://app.devin.ai/sessions/b477b6dc23784c18940aeae81802106c
Requested by: @kphunter

Co-Authored-By: kyle_hunter@bcit.ca <kyle_hunter@bcit.ca>
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@kphunter kphunter merged commit 0e20687 into main May 25, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant