ci: standardize workflows and chart patterns to match org playbook#18
Merged
Conversation
Co-Authored-By: kyle_hunter@bcit.ca <kyle_hunter@bcit.ca>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aligns conversion-guide CI/CD workflows and documentation with the qcon-api reference implementation:
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24, OCI image/chart registry paths, and release-please annotations; updated Project Structure to use/path— description format with/.github/workflows/entry$GITHUB_OUTPUTreferences for shell safety; renamedTAGS→TAG_ARGSvariable to match qcon-api conventionAll other standardization items (checkout@v6, FORCE_JAVASCRIPT_ACTIONS_TO_NODE24, helm push error guard, tolerant digest parse, yq chart name extraction, shell-safe GHA env blocks, digest guard on sign steps, Chart.yaml annotations, release-please-config.json, affinity conditional) were already applied in a prior PR.
Review & Testing Checklist for Human
TAG_ARGSrename doesn't conflict with any external referencesNotes
Helm lint and kubeconform validation both pass locally. No functional workflow changes — only documentation and shell quoting improvements.
Link to Devin session: https://app.devin.ai/sessions/b477b6dc23784c18940aeae81802106c
Requested by: @kphunter