Conversation
panish16
requested review from
davemck513,
hfekete,
mengdong19,
ozamani9gh,
rarmitag and
stevenc987
as code owners
Anish, please rebase and then bump up the app version. I recommend using version 5.9.0. |
| patchedDependencies: | ||
| sbc-common-components@3.0.15-c: | ||
| hash: dbxsbs7nnq5sxpyu75cpekwise | ||
| hash: 04ee617a4ac7ced8e6cfab349eeccdc740e5a5be3543ee92d05d0966a39046be |
There was a problem hiding this comment.
This change concerns me. It may be that you have to re-patch this package (or this may be a Node 24 thing, I dunno).
If you have to re-patch, look up how to do it and look at the current patch (as per the path at the bottom of the package.json file).
Otherwise, you might be able to get away with simply leaving THIS file unchanged (ie, uncommit it).
You'll have to test if that works either way.
|
@panish16 You have two outstanding comments above before this PR can be merged. Also, please chase down the other reviewers for this code change -- another team (not Entities) owns this repo. Thanks. |
3 participants
Issue #: https://app.zenhub.com/workspaces/sre-team-board-654d163c6817d80016102d9a/issues/gh/bcgov/entity/32835
Description of changes:
Update engines field in package.json to require Node.js >= 24.
Update GitHub Actions CI/CD workflows to use Node 24.
Align with modern runtime standards and ensure pipeline stability.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).