#5599 - Active SIN Numbers External API

[tiago-graf]

Summary

Implements a new GET /external/student/full-time-active-sins endpoint for the external client that returns the list of distinct active SINs for full-time students.

[Copilot]

Pull request overview

Implements a new External student API endpoint to retrieve distinct “active” SINs for full-time students by querying both SIMS (current) and SFAS (legacy) data sources.

Changes:

• Added StudentInformationService query methods to fetch distinct active full-time SINs from SIMS and SFAS.
• Added GET endpoint on StudentExternalController returning combined SINs via ActiveSINsAPIOutDTO.
• Added e2e coverage validating inclusion/exclusion rules for SIMS and SFAS scenarios.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File	Description
sources/packages/backend/apps/api/src/services/student/student-information.service.ts	Adds query-builder methods to find “active” full-time SINs in SIMS and SFAS.
sources/packages/backend/apps/api/src/route-controllers/student/student.external.controller.ts	Exposes a new external GET endpoint that returns the merged SIN list.
sources/packages/backend/apps/api/src/route-controllers/student/models/student-external-search.dto.ts	Adds output DTO for the new endpoint response shape.
sources/packages/backend/apps/api/src/route-controllers/student/tests/e2e/student.external.controller.getActiveSINs.e2e-spec.ts	Adds e2e tests for inclusion/exclusion logic and authentication.

[sh16011993]

Nice work @tiago-graf 👍

[github-actions]

E2E SIMS API Coverage Report

Totals
Statements:	65.62% ( 13029 / 19854 )
Methods:	62.57% ( 1538 / 2458 )
Lines:	69.22% ( 9450 / 13653 )
Branches:	54.53% ( 2041 / 3743 )

[dheepak-aot]

Thanks for making the changes. Added few more comments.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Backend Unit Tests Coverage Report

Totals
Statements:	20.1% ( 4579 / 22781 )
Methods:	9.45% ( 262 / 2773 )
Lines:	24.48% ( 3931 / 16059 )
Branches:	9.77% ( 386 / 3949 )

[github-actions]

E2E Workflow Workers Coverage Report

Totals
Statements:	48.27% ( 2713 / 5620 )
Methods:	38.26% ( 285 / 745 )
Lines:	55.14% ( 2050 / 3718 )
Branches:	32.67% ( 378 / 1157 )

[github-actions]

E2E Queue Consumers Coverage Report

Totals
Statements:	79.33% ( 9156 / 11542 )
Methods:	78.47% ( 1181 / 1505 )
Lines:	82.66% ( 6882 / 8326 )
Branches:	63.88% ( 1093 / 1711 )

[dheepak-aot]

Thanks for making the changes. Looks good 👍