Fix GCC build: add missing unistd.h for usleep()#3
Open
Hughpig wants to merge 2 commits intobbuhrow:mainfrom
Open
Fix GCC build: add missing unistd.h for usleep()#3Hughpig wants to merge 2 commits intobbuhrow:mainfrom
Hughpig wants to merge 2 commits intobbuhrow:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes GCC 11+ implicit declaration errors for usleep() by adding the appropriate POSIX header include in the threadpool implementation.
Changes:
- Add
<unistd.h>include to provide theusleep()declaration on POSIX/GCC. - Minor whitespace-only diff noise (license block reflow in diff + trailing blank line).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
25
to
29
| #include <stdint.h> | ||
| #include <stdio.h> | ||
| #include "threadpool.h" | ||
| #include <unistd.h> | ||
|
|
There was a problem hiding this comment.
#include <unistd.h> is currently unconditional, which can break Windows/MSVC builds since <unistd.h> is POSIX-only. Please guard this include (e.g., under the existing #if defined(WIN32) || defined(_WIN64) / #else split) or move it into the non-Windows branch near the usleep() usage.
Author
There was a problem hiding this comment.
@copilot open a new pull request to apply changes based on this feedback
Restored the MIT License header and included necessary headers for thread pool implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
usleep()requires<unistd.h>on POSIX systems.Fixes implicit declaration error with GCC 11+.