snapd: update to 2.71, add image-garden support#35
Merged
Conversation
One more hack was needed to let the package to build in the current form, without proper support for Go modules. I've filed an internal tracking ticket for the next release so that we re-do the package with new Go helpers, remove a lot of generated content that is instead generated at build time, and actually support Go modules for real. https://warthogs.atlassian.net/browse/SNAPDENG-35431 (not visible to the public, apologies, this helps only a limited audience). Signed-off-by: Zygmunt Krynicki <me@zygoon.pl>
When we remove the vendor directory, remove the C quivalent as well. Signed-off-by: Zygmunt Krynicki <me@zygoon.pl>
Signed-off-by: Zygmunt Krynicki <me@zygoon.pl>
Instead, generate the required data by hand. This avoids the need to "go run" during the build process. Signed-off-by: Zygmunt Krynicki <me@zygoon.pl>
Signed-off-by: Maciek Borzecki <maciek.borzecki@gmail.com>
Signed-off-by: Maciek Borzecki <maciek.borzecki@gmail.com>
Owner
Author
zyga
approved these changes
Sep 15, 2025
zyga
left a comment
zyga
left a comment
Collaborator
There was a problem hiding this comment.
LGTM
Do you want to enable spread on the repo?
| # - opensuse-tumbleweed-64 => opensuse-cloud-tumbleweed.$(uname -m) | ||
| # - ubuntu-24.04-64 => ubuntu-cloud-24.04.$(uname -m) | ||
| # - ubuntu-core-24-64 => ubuntu-cloud-24.04.$(uname -m) | ||
| exec image-garden allocate "$(echo "$SPREAD_SYSTEM" | sed \ |
Collaborator
There was a problem hiding this comment.
Since there is no prescribed meaning like in snapd.git, perhaps we could just use the garden names directly?
Owner
Author
There was a problem hiding this comment.
There's already some logic in prepare which looks at $SPREAD_SYSTEM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge changes from Fedora rawhide packaging thus updating snapd to 2.71.
Include image-garden support for easier CI.