examples: temporary fix for cmake_hello_world_lib/shared on windows#1475
Merged
examples: temporary fix for cmake_hello_world_lib/shared on windows#1475
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the cmake_hello_world_lib/shared example tests to avoid a known Windows runtime issue with copying DLLs when running cc_test, while still keeping some validation in place.
Changes:
- Mark
:test_libhelloas incompatible on Windows viatarget_compatible_with. - Add a
bazel_skylibbuild_testtarget to ensure:libhelloat least builds.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This fails due to a bug in bazel / in rules_cc (depending on bazel version). See bazelbuild/rules_cc#623
novas0x2a
force-pushed
the
novas0x2a-fix-cmake-shared
branch
from
d080181 to
9d40368
Compare
cerisier
approved these changes
Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fails due to a bug in bazel / in rules_cc (depending on bazel version). See bazelbuild/rules_cc#623. With upstream's approval I plan to roll this fix out everywhere.