Implement web sources crawling and scrapping features#263
Open
Mascode-Dev wants to merge 44 commits into
Open
Conversation
embeddings pipeline
instantly in the UI
…pletion for dropdown
…uments from web sources
…or on crawl failure
jdoucy
reviewed
May 7, 2026
| } | ||
|
|
||
| @CheckPolicy((policy) => policy.canList()) | ||
| @Sse(DocumentsRoutes.streamCrawlProgress.path, { method: 0 /* GET */ }) |
Member
There was a problem hiding this comment.
RequestMethod.GET (but its already the case inside the codebase)
| return ( | ||
| await this.documentConnectRepository.find(connectScope, { | ||
| where: { sourceType: "project", uploadStatus: "uploaded" }, | ||
| where: [ |
| children: React.ReactNode | ||
| }) { | ||
| const { hasFeature } = useFeatureFlags() | ||
| const { hasFeature, isLoading } = useFeatureFlags() |
| if (project) { | ||
| return { | ||
| hasFeature: (feature: FeatureFlagKey): boolean => check(project.featureFlags || [], feature), | ||
| isLoading: false, |
Member
There was a problem hiding this comment.
remove your change and it should work
| documentId: z.string(), | ||
| documentTitle: z.string(), | ||
| documentFileName: z.string().nullable(), | ||
| documentSourceType: z.string(), |
| effect: async (action, listenerApi) => { | ||
| syncDocumentEmbeddingStatusStreamWithDocuments(listenerApi) | ||
|
|
||
| // Refetch documents when a webCrawl document finishes embedding |
Member
There was a problem hiding this comment.
Create an issue to refactor / clean this
| files: File[] | ||
| sourceType: DocumentSourceType | ||
| tagIds?: string[] | ||
| name?: string |
| return parsed | ||
| } | ||
| } catch { | ||
| // not JSON, not a crawl document |
Member
There was a problem hiding this comment.
Why parsing crawled page in frontend?
| }) { | ||
| const date = buildSince(document.updatedAt) | ||
| const isWebCrawl = document.sourceType === "webCrawl" | ||
| const crawledPages = isWebCrawl ? parseCrawledPages(document.content) : null |
Member
There was a problem hiding this comment.
Why? just webcrawl sourceType is not enough?
| ### Added | ||
| - Display evaluation extraction run metrics in Bull Board | ||
| - Retry failed evaluation extraction runs from the UI | ||
| - (beta) Documents sidebar entry replaced by a Sources dropdown with separate Documents and Websites sections |
Member
There was a problem hiding this comment.
Simplify, (beta) we can scrap web sources
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Frontend changes
Backend changes