feat: replace hardcoded Uniswap API key with per-operator developer-portal key#145
Open
Ponx wants to merge 1 commit into
Open
feat: replace hardcoded Uniswap API key with per-operator developer-portal key#145Ponx wants to merge 1 commit into
Ponx wants to merge 1 commit into
Conversation
Collaborator
🟡 Heimdall Review Status
|
…ortal key The plugin shipped a shared, hardcoded x-api-key. A public key lets anyone call the API without being bound to Uniswap's developer terms, and pools RPS across everyone while attracting spam. Direct each operator to generate their own free key on the Uniswap developer portal instead. - Remove the hardcoded key; use a <UNISWAP_API_KEY> placeholder - Rewrite ## Auth: portal sign-up flow (auto-generates a key), operator-driven (default) vs agent-driven (browser + inbox) completion paths, and key-handling rules (prefer secrets, paste in full, never echo/log or put in calldata) - Add an onboarding IMPORTANT callout and a Notes pointer to the portal - Note the API-key requirement in the SKILL.md plugin catalog row - Bump plugin version 0.2.0 -> 0.3.0 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
5ab6d28 to
16bf34c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Uniswap plugin shipped a shared, hardcoded
x-api-keyin## Auth. This is counter to Uniswap's legal posture and operationally fragile:The fix is to have each operator generate their own free key on the Uniswap developer portal, which binds their usage to the terms and scopes rate limits to them.
What changed
skills/base-mcp/plugins/uniswap.md:<UNISWAP_API_KEY>placeholder (also required by the plugin spec — no secret values in plugin files).## Auth:send_callscalldata, one key per operator.> [!IMPORTANT]onboarding callout flagging the key as a prerequisite, plus a Notes pointer to the portal.version0.2.0 → 0.3.0.skills/base-mcp/SKILL.md:Notes for reviewers
x-api-key) and the auto-generation-on-signup flow were confirmed against Uniswap's Trading API quickstart / overview. The exact post-signup dashboard UI is behind auth and was not directly verified.🤖 Generated with Claude Code