fix(attachments): use downloads API instead of a.click() in popup#55
Merged
Conversation
The programmatic anchor-click approach caused Firefox to close the popup (focus loss during download initiation), making attachment downloads look like they did nothing. Replace with api.downloads.download() which is the correct extension API for initiating downloads from a popup context. Also surfaces download errors visually (red border on the button) and logs them to the console, so failures are no longer completely silent. Adds the "downloads" manifest permission required by the API. https://claude.ai/code/session_011k8zuM3FhFRooN1fpGYhNi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
a.click()blob-URL trick withapi.downloads.download(), the correct Firefox extension API for initiating file downloads from a popup context"downloads"manifest permission required by the APIconsole.error— failures are no longer silent