feat(detail): collapse attachments when count exceeds 2#54
Merged
Conversation
When an email has more than 2 attachments, replace the flat list with a summary row showing the count and up to 3 file-type chips. Clicking the row toggles a fixed-height (160 px) scrollable list of all attachment items; clicking again collapses it. https://claude.ai/code/session_011k8zuM3FhFRooN1fpGYhNi
There was a problem hiding this comment.
Pull request overview
Adds a collapsed/expandable attachments UI in the email detail view when an email has more than two attachments, while keeping the existing flat list behavior for 1–2 attachments.
Changes:
- Refactors attachment row creation into a helper and introduces a collapsible “attachment summary” row for 3+ attachments.
- Adds new CSS for the attachment summary row, type chips, chevron animation, and a max-height scrollable expanded list.
- Updates
package-lock.jsonwith platform-metadata changes (unrelated to the UI feature).
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/popup/popup.css | Adds styling for the new attachment summary row, type chips, chevron, and scrollable expanded list. |
| src/popup/detail.js | Implements the collapsed/expandable attachment list behavior and extracts attachment item rendering into a helper. |
| package-lock.json | Removes libc metadata from several Rollup platform optional packages (scope unrelated to this feature). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PDF,PNG,DOCX) sorted by frequencyTest plan
aria-expandedbecomestruePDFchip first)https://claude.ai/code/session_011k8zuM3FhFRooN1fpGYhNi
Generated by Claude Code