feat: deprecate url_encode/url_decode/parse_url URL surface (PUNY-vpegoytz)#22
Merged
Merged
Conversation
…goytz) Phase 2a of item C: wind down the best-effort URL surface in favour of `rurl` for URL parsing/canonicalization and host_normalize()/puny_encode()/ puny_decode() for host-only needs. - Add .Deprecated() warnings to the three R wrappers, pointing callers at the replacement surface; mark them @Keywords internal (kept exported and fully functional this release). - NEWS.md: announce deprecation + planned removal next release. - Tests: assert the deprecation warning (class + replacement-surface hints); wrap the behavioural tests in a deprecatedWarning muffler so the suite stays green and NA-input warnings still surface where expected. C++ (punycoder_url.cpp), Rcpp shims, and runtime behaviour are unchanged. Removal is tracked separately as phase 2b (PUNY-rumdaymk). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…ytz) The dev heading embedded both the version and '(development version)', which the news-version gate accepts in neither form. Use the standard '# punycoder (development version)' so the check passes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The lint gate (LINTR_ERROR_ON_LINT) surfaced 8 pre-existing line-length violations in normalize.R and the normalize/idna-conformance test files, unrelated to the deprecation slice but blocking this PR's CI. Rewrap the long lines (and split one long profile-token literal via paste0) so lint_package() reports zero. No behaviour change. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 2a of item C (parent audit PUNY-emjvtzlr): deprecate the best-effort URL surface ahead of removal next release. Confirmed safe — nothing upstack consumes punycoder's URL functions (
rurlparses viacurl::curl_parse_urland only callspuny_encode/puny_decodefor the host;pslruseshost_normalize/puny_decode). Pure API wind-down, not a migration.url_encode()/url_decode()/parse_url()now emit a.Deprecated()warning pointing callers atrurl(URL parsing/canonicalization) andhost_normalize()/puny_encode()/puny_decode()(host-only needs).@keywords internalbut remain exported and fully functional this release.punycoder_url.cpp), Rcpp shims, and runtime behaviour are unchanged.Tests
deprecatedWarningis emitted and its message names the replacement surface.deprecatedWarningmuffler (suppress_url_deprecation()) so they stay focused on behaviour; NA-input warnings still surface for the tests that expect them.[ FAIL 0 | WARN 0 | SKIP 0 | PASS 382 ]. Zero new lint violations.Removal is tracked separately as phase 2b (PUNY-rumdaymk).
🤖 Generated with Claude Code