ux(reactions): expand "More reactions" footer hit target to full row#343
Open
dmnyc wants to merge 1 commit into
Open
ux(reactions): expand "More reactions" footer hit target to full row#343dmnyc wants to merge 1 commit into
dmnyc wants to merge 1 commit into
Conversation
The footer button in `EmojiReactionPicker` was wrapping its `HStack { icon, label }` in a `.frame(maxWidth: .infinity)` but only the glyph + label bounds registered taps. Tapping in the blank space on either side of the label missed, even though the row visually filled the picker's width. Add a `.contentShape(Rectangle())` so the full row hit area registers — "More reactions" is the most common action after the curated grid and deserves the easiest target in the picker.
Closes #325.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The footer button in
EmojiReactionPickerwas wrapping itsHStack { icon, label }in a.frame(maxWidth: .infinity)but only the glyph + label bounds registered taps. Tapping in the blank space on either side of the label missed, even though the row visually filled the picker's width. Add a.contentShape(Rectangle())so the full row hit area registers — "More reactions" is the most common action after the curated grid and deserves the easiest target in the picker.Files
EmojiReactionPicker.swift—+7 / -0Test plan
Closes #325.