fix(notifications): show total zap count instead of 24h-only sats#269
Open
dmnyc wants to merge 1 commit into
Open
fix(notifications): show total zap count instead of 24h-only sats#269dmnyc wants to merge 1 commit into
dmnyc wants to merge 1 commit into
Conversation
Zap badge was showing sats from only the last 24h, so any zap older than that appeared in the list but counted as zero. Also, bolt11 decode failures silently zeroed the sats figure even when zap rows were visible. - Remove 24h cutoff from computeSummary so counts match the list - Badge now shows zapCount (consistent with every other category)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes:
computeSummary24h()so the counts reflect every item in the buffer (matching what the list shows)zapCount, consistent with how every other category (reactions, replies, reposts) is displayedTest plan