This repository was archived by the owner on Sep 10, 2025. It is now read-only.
Add fallback to GET if HEAD doesn't work#9
Open
samdbmg wants to merge 6 commits intobarneygale:masterfrom
Open
Add fallback to GET if HEAD doesn't work#9samdbmg wants to merge 6 commits intobarneygale:masterfrom
samdbmg wants to merge 6 commits intobarneygale:masterfrom
Conversation
Fixes test failures when mocking async code.
Adds a fallback behaviour when either `no_head_request` is set, or the original HEAD request returns a 403 or 405 code. Mitigates cases where HEAD isn't implemented (405), and also a specific problem with AWS S3 presigned URLs which will can't be generated for more than one method, so will return 403 on HEAD.
Adds the same fallback behaviour to the async implementation.
Adds a parameter to pass kwargs to the ClientSession constructor, for example so that `trust_env` can be set when working behind proxies.
jamesba
approved these changes
Jul 29, 2021
Contributor
jamesba
left a comment
jamesba
left a comment
There was a problem hiding this comment.
Looks good to me, I'd probably use an async exit stack these days, but that's a bigger change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This works around a problems where servers don't support HEAD correctly, such as AWS S3 presigned URLs which incorporate the method into the URL signature, so you can't produce one that supports both GET and HEAD. This PR adds a fallback behaviour in response to
405 Method Not Implementedor403 Forbidden(S3's response) on HEAD to try a GET instead, but avoids reading the response body to prompt the server not to send any more data.I've also made a tweak to the unit tests in the process to generate data with the slightly faster (but less random)
random.getrandbitsand factor out sample data generation across both tests.cc @jamesba - would you mind reviewing this too?