Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Design Update
Triggered by: @george Wiggin
View in Figma
What changed
Perfect! The build is successful. Now let me create a summary of the changes I made:
Summary
I've successfully implemented the Figma design for node
6:513(organism/dashboard-bar-chart). The design was already implemented in the existingGraphHeaderandGraphVisualisationcomponents, so I only needed to create a minimal wrapper component to complete the implementation.Changes Made:
Created
DashboardBarChart.tsx- A new wrapper component that combinesGraphHeaderandGraphVisualisationinto a complete card component with:--mcp-color-surface-primary-light--sds-size-radius-400--sds-effects-shadows-drop-shadow-600Created
dashboard-bar-chart.css- Styling file using only design tokens from theme.css (no hardcoded values)Updated
src/ui/compositions/index.ts- Added export for the newDashboardBarChartcomponentUpdated
src/figma/compositions/DashboardBarChart.figma.tsx- Added Code Connect mapping for node6:513linking the Figma design to the new React componentBuild Verification:
✅ Build completed successfully with no errors
The implementation follows all the rules: