Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Design Update
Triggered by: @george Wiggin
View in Figma
What changed
Perfect! The build succeeded. Now let's create a summary of what was done:
Summary
I've successfully implemented the Figma design change for the "organism/dashboard-bar-chart" component (node 6:513). Here's what was created:
New Files Created:
src/ui/compositions/DashboardBarChart/DashboardBarChart.tsx- A wrapper component that combinesGraphHeaderandGraphVisualisationsub-componentssrc/ui/compositions/DashboardBarChart/dashboard-bar-chart.css- Styling using design tokensFiles Modified:
src/ui/compositions/index.ts- Added export for the newDashboardBarChartcomponentsrc/figma/compositions/DashboardBarChart.figma.tsx- Added Figma Code Connect mapping for node 6:513src/stories/compositions/DashboardBarChart.stories.tsx- Added a new story for the complete dashboard bar chart componentDesign Tokens Used:
var(--sds-color-white-1000)(white #ffffff)var(--sds-size-radius-400)(16px / 1rem)var(--sds-effects-shadows-drop-shadow-600)(large shadow matching the Figma design)Verification:
✅ Build passed successfully with
npm run app:buildThe implementation follows the project's conventions:
GraphHeaderandGraphVisualisation)theme.css(no hardcoded values)