Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Design Update
Triggered by: @george Wiggin
View in Figma
What changed
Excellent! The implementation is complete. Let me provide a summary of what was done.
Summary
I've successfully implemented the Figma design changes for the DashboardBarChart component (node 6:513). Here's what was created:
Changes Made
New Files Created:
src/ui/compositions/DashboardBarChart/DashboardBarChart.tsx- Main wrapper component that combines GraphHeader and GraphVisualisation into a complete cardsrc/ui/compositions/DashboardBarChart/dashboard-bar-chart.css- Styling for the card wrapper with:var(--mcp-color-surface-primary-light)var(--sds-size-radius-400)var(--sds-effects-shadows-drop-shadow-600)Modified Files:
3.
src/ui/compositions/index.ts- Added export for the new DashboardBarChart component4.
src/figma/compositions/DashboardBarChart.figma.tsx- Added Figma Code Connect mapping for node 6:5135.
src/stories/compositions/DashboardBarChart.stories.tsx- Added a new Storybook story for the complete componentDesign Alignment
The implementation follows the Figma design exactly:
theme.css(no hardcoded values)Verification
✅ Build successful:
npm run app:buildpasses without errorsThe implementation is minimal and only adds the necessary wrapper component to match the Figma design. The existing GraphHeader and GraphVisualisation components were already correct and required no changes.