hw.device-type: switch to using flashProtocol: jetsonFlashDirect#446
Draft
hw.device-type: switch to using flashProtocol: jetsonFlashDirect#446
Conversation
Contributor
vipulgupta2048
left a comment
vipulgupta2048
left a comment
There was a problem hiding this comment.
Same review for everywhere partials were deleted. LGTM otherwise.
| ], | ||
| "flashIndicator": ["power LED is off"], | ||
| "bootDevice": ["Remove recovery mode jumper and power up the {{name}}"] | ||
| "bootDevice": ["Connect power to the {{name}}"] |
Contributor
There was a problem hiding this comment.
I rather not remove the partials for any of these becoming jetsonFlashDirect @acostach Let's keep them for historically purposes since creating these took effort and it's not bad to keep them around IMO other some technical debt.
Contributor
Author
There was a problem hiding this comment.
ok, I added the partials back
... for devices which have detailed instructions in the jetson-flash repository. Devices which are SD-CARD flashers stay un-changed, so do community boards which don't have dedicated pages in the jetson-flash documentation. Change-type: patch Signed-off-by: Alexandru Costache <alexandru@balena.io>
acostach
force-pushed
the
switch_to_redirect
branch
from
1319aba to
ee7fde9
Compare
auto-merge was automatically disabled
December 4, 2024 13:16
Pull request was converted to draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... for devices which have detailed instructions in the jetson-flash repository.
Devices which are SD-CARD flashers stay un-changed, so do community boards which don't have dedicated pages in the jetson-flash documentation.
Needed by: balena-io/balena-sdk#1503
Change-type: patch