Move computeCurrentSpotPrice to helper#160
Merged
EndymionJkb merged 41 commits intoreclamm-2.1from Mar 6, 2026
Merged
Conversation
Co-authored-by: EndymionJkb <EndymionJkb@gmail.com>
…e trouble than it's worth, and associated helpers
…he for performance; for consistency, use current live balances in _updateVirtualBalances, to prevent rate drift; computeCurrentPoolCenteredness should call _computeCurrentVirtualBalances, like all other view functions; also address stale interface comments
…and virtual); remove unnecessary helper
jubeira
reviewed
Mar 6, 2026
# Conflicts: # contracts/ReClammPool.sol # contracts/interfaces/IReClammPool.sol # test/foundry/ReClammPool.t.sol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move the
computeCurrentSpotPricefunction to the helper. Per comment, could move others as well if they're not used by the SDK.Minor extraneous thing: fix warning about casting address types
Type of change
Checklist:
main, or there's a description of how to mergeIssue Resolution