Skip to content

Use new CircleCI "convenience" images#7726

Merged
repo-ranger[bot] merged 6 commits into
masterfrom
circle-images
Mar 25, 2022
Merged

Use new CircleCI "convenience" images#7726
repo-ranger[bot] merged 6 commits into
masterfrom
circle-images

Conversation

@paulmelnikow
Copy link
Copy Markdown
Member

@paulmelnikow paulmelnikow commented Mar 15, 2022

Here's a shot at addressing #7725.

After looking through this list, it looks like they provide aliases for the minor node versions but not the major versions.

Closes #7725

@shields-ci
Copy link
Copy Markdown

shields-ci commented Mar 15, 2022

Messages
📖 ✨ Thanks for your contribution to Shields, @paulmelnikow!

Generated by 🚫 dangerJS against ac26f1d

@paulmelnikow
Copy link
Copy Markdown
Member Author

Looks like this is working 👍🏼

@paulmelnikow paulmelnikow marked this pull request as ready for review March 15, 2022 18:49
@chris48s
Copy link
Copy Markdown
Member

Cheers for having a look at this.
I think the notification we got is actually about the package tests. As I understand it, machine: true requires an update and will be affected by the brownouts:

package:
machine: true

It uses a base image because it then uses nvm to install node versions on top of it.

I think independently of this, the circleci/ images were deprecated last year, so also need updating to the cimg/ ones (so that is still useful) but I think its actually a separate issue.

Its a bit of a pain that there isn't a plain old node:16 or node:17 tag we can use on those

@paulmelnikow
Copy link
Copy Markdown
Member Author

Aha! Good shout. Will have another pass at that.

@chris48s
Copy link
Copy Markdown
Member

This should be good now

@chris48s chris48s added the developer-experience Dev tooling, test framework, and CI label Mar 24, 2022
@repo-ranger repo-ranger Bot merged commit 203afbc into master Mar 25, 2022
@repo-ranger repo-ranger Bot deleted the circle-images branch March 25, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

developer-experience Dev tooling, test framework, and CI

Development

Successfully merging this pull request may close these issues.

Migrate Circle CI builds away from Ubuntu 14.04

5 participants