Introduce context-menu submenus#119
Open
goanpeca wants to merge 5 commits into
Open
Conversation
Extension Build ReadyDownload the VSIX from the workflow artifacts above. InstallationVS Code UI: Extensions > ... > Install from VSIX... CLI: |
There was a problem hiding this comment.
Pull request overview
This PR introduces initial VS Code context-menu submenu infrastructure for the B2 extension by declaring submenu IDs in the extension manifest, moving file “copy” actions under a file-only submenu anchor, and adding tests/contract updates to lock in the contribution shape.
Changes:
- Added
contributes.submenusdeclarations for the proposed file/bucket submenu structure. - Reworked
view/item/contextcontributions so file copy commands live under ab2.file.copysubmenu anchor (while bucket/folder copy remains flat until it has a second member). - Added/updated manifest-focused tests and updated the release contract
contributesSha256.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
package.json |
Declares submenu IDs and introduces the b2.file.copy submenu + anchor in view item context menus. |
src/test/suite/extension.test.ts |
Adds tests asserting submenu declarations, anchor gating behavior, and the “no one-item submenu” rule. |
scripts/release-contract.js |
Updates the frozen contributesSha256 to reflect the manifest contribution change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
a0d133f to
b031fc4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
b2.file.copycontext-menu submenu and keep future submenu IDs undeclared until they have at least two concrete members.b2.file.copysubmenu, keep bucket/folder copy as flat items, and gate file copy submenu plus inline file copy actions withb2.canListFiles.AuthServiceso manual auth and auto-auth share the same capability mapping.Linked issue
Closes #102
Tests run
Follow-up notes