BBC2-41 add GitHub Actions workflow to run bun test on PRs#11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/ci.yml.main.bun install --frozen-lockfile→bunx tsc --noEmit→bun test.concurrencycancels superseded runs on the same ref so rapid pushes don't queue duplicate jobs.bun testdoesn't catch type errors on its own; putting tsc first fails fast.Manual follow-up
Requiring CI to pass before merge is a GitHub branch-protection setting, not something this PR can enable. After landing, configure at https://github.com/b2l/bbcli/settings/branches → add a rule for
main→ require thetestcheck.Test plan
bunx tsc --noEmit— cleanbun test— 128 pass