Refactor subtile to TileInfo architecture with modular emit files#39
Draft
b-shi wants to merge 3 commits into
Draft
Refactor subtile to TileInfo architecture with modular emit files#39b-shi wants to merge 3 commits into
b-shi wants to merge 3 commits into
Conversation
b-shi
commented
Apr 28, 2026
b-shi
commented
Owner
- Replace monolithic SubtileBasedKernel.py with modular Subtile/ package
- Split emit logic into SubtileGREmit.py, SubtileLREmit.py, SubtileScaleEmit.py, SubtileGeometry.py
- Introduce TileInfo_ frozen geometry class replacing legacy TileInfo
- Integrate LogicalScheduler from subtile_mx with TileInfo_ architecture
- Method renames: grSubtileRegIdx -> grRegGroupForSubtileRow, grLoadIndex -> grLoadIndexForSubtile, lrTileIndex -> lrTileIndexForSubtile
- Add lrSubtileShape, lrLocalSubtileGrid, loadRatioLR fields
- Update loadRatioGR formula to use subtileSize * blockCount
- Remove legacy ScheduleInfo, rename allocVgprTileRegisters -> _legacy
- Add test_tileinfo_compare, test_tileinfo_fields, test_gr_offset
nakajee
reviewed
Apr 28, 2026
b-shi
force-pushed
the
save/subtile_mx_rebase_v1
branch
from
9d3d904 to
51dedf8
Compare
- Replace monolithic SubtileBasedKernel.py with modular Subtile/ package - Split emit logic into SubtileGREmit.py, SubtileLREmit.py, SubtileScaleEmit.py, SubtileGeometry.py - Introduce TileInfo frozen geometry class replacing legacy TileInfo - Integrate LogicalScheduler from subtile_mx with TileInfo architecture - Method renames: grSubtileRegIdx -> grRegGroupForSubtileRow, grLoadIndex -> grLoadIndexForSubtile, lrTileIndex -> lrTileIndexForSubtile - Add lrSubtileShape, lrLocalSubtileGrid, loadRatioLR fields - Update loadRatioGR formula to use subtileSize * blockCount - Remove legacy ScheduleInfo, rename allocVgprTileRegisters -> _legacy - Add test_tileinfo_compare, test_tileinfo_fields, test_gr_offset Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>
b-shi
force-pushed
the
save/subtile_mx_rebase_v1
branch
from
51dedf8 to
92be082
Compare
sebvince
reviewed
Apr 30, 2026
Collaborator
There was a problem hiding this comment.
Should we rename it to InstructionEmitter as well ? (now it's in subtile dir)
sebvince
reviewed
Apr 30, 2026
|
|
||
| # Row-major A/B: GR and LR both contiguous along K | ||
| AB_B16 = ABTilePair( | ||
| gr=ABGRGeometry(tag=GRTag_1x2(), **_B16, blockShape=(1, 2), loadShape=LoadShape(m=1, k=8)), # 128-bit GR: 8 bf16 along K |
Collaborator
There was a problem hiding this comment.
aren't blockShape and subtileShape the same thing ? I mean why do we need 2 different names ?
sebvince
reviewed
Apr 30, 2026
| 2x2 WG: A=(1,2), B=(1,2) — 2 cooperating waves each | ||
| 1x1 WG: A=(1,2), B=(1,2) — 1 wave each | ||
|
|
||
| LR subtile shape is always (1,2) regardless of wave config. |
Collaborator
There was a problem hiding this comment.
Actually we currently use (1,1) in the scheduler. This is for current PGR0 codepath I guess ?
amd-chunxlin
left a comment
amd-chunxlin
left a comment
There was a problem hiding this comment.
Small suggestion: may consider the copyright below to avoid yearly updates:
// Copyright Advanced Micro Devices, Inc., or its affiliates.
// SPDX-License-Identifier: MIT
|
This looks good to me. I don't have any detailed reviews for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.