Skip to content

[codex] Support Korean Codex settings labels#533

Draft
hellosunghyun wants to merge 1 commit into
b-nnett:mainfrom
hellosunghyun:codex/korean-settings-menu-labels
Draft

[codex] Support Korean Codex settings labels#533
hellosunghyun wants to merge 1 commit into
b-nnett:mainfrom
hellosunghyun:codex/korean-settings-menu-labels

Conversation

@hellosunghyun

Copy link
Copy Markdown

Summary

  • Add Korean Codex Settings and main navigation labels to the settings sidebar detection heuristics.
  • Rebuild the checked-in preload runtime assets so Codex++ injects the ++ menu in Korean-localized Codex.
  • Add a regression test that checks both source and bundled settings injector output include the Korean labels.

Root cause

The settings injector identifies the Codex Settings sidebar by matching known localized item labels. The 1.0.0 label set covered English and Chinese labels, but not Korean labels, so the sidebar was not detected and the Codex++ menu was never injected when Codex was set to Korean.

Validation

  • npm ci
  • npm test
  • node --import tsx --test packages/runtime/test/settings-injector-labels.test.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant