fix: detect current Codex settings sidebar#46
Draft
CreepsoOff wants to merge 1 commit into
Draft
Conversation
shaneholloman
pushed a commit
to shaneholloman/codex-plusplus
that referenced
this pull request
May 14, 2026
Includes PR b-nnett#46 settings sidebar detection fix. Co-authored-by: CreepsoOff <51055703+CrepsoOff@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Codex++ Settings sidebar injection on the current Codex Desktop Settings UI.
The previous detection logic depended on older Settings sidebar assumptions, especially the presence of
Back to app. Current Codex Settings no longer always exposes that label, and the available Settings entries can vary by platform, region, and feature availability.This updates
settings-injector.tsto detect the Settings sidebar by scoring known navigation labels instead of requiringBack to app.Settings variants
The detection is intentionally score-based rather than an exact full Settings list. Some entries can vary, for example
Computer use/Computer Usemay appear for some users but not others.The matcher normalizes case, spacing, and diacritics, and only requires:
Tested
Tested locally on Windows with:
OpenAI.Codex_26.429.8261.0_x64__2p2nqsd0c76g0Build command:
Result:
The Settings sidebar now correctly shows Codex++ / Config / Tweaks / Tweak Store.
Successful logs:
[settings-injector] settings surface {"visible":true,"reason":"sidebar-found"} [settings-injector] nav group injected {"outerTag":"NAV"} [settings-injector] pages group synced {"count":3}Known follow-up
The injector can still emit noisy
sidebar not foundlogs while Settings is not mounted or during remounts. This PR focuses on restoring functional sidebar detection.