Skip to content

fix: remove clear all or select all if all options are disabled.#117

Merged
azeezat merged 1 commit intomainfrom
fix/remove-clear-all-when-all-options-are-disabled
Jun 30, 2025
Merged

fix: remove clear all or select all if all options are disabled.#117
azeezat merged 1 commit intomainfrom
fix/remove-clear-all-when-all-options-are-disabled

Conversation

@azeezat
Copy link
Owner

@azeezat azeezat commented Jun 30, 2025

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #116

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
    simulator_screenshot_A45A47A0-E7A0-49F8-B195-8EB3782380DF

  • Test B
    simulator_screenshot_0A5F9E6D-81DD-4BDC-A8DA-CC5B478AED0D

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@github-actions
Copy link

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 97.87% 276/282
🟢 Branches
91.44% (+0.08% 🔼)
203/222
🟢 Functions 96.3% 104/108
🟢 Lines 98.19% 271/276

Test suite run success

26 tests passing in 3 suites.

Report generated by 🧪jest coverage report action from 614235d

@azeezat azeezat self-assigned this Jun 30, 2025
@azeezat azeezat merged commit 34c633c into main Jun 30, 2025
8 checks passed
@azeezat
Copy link
Owner Author

azeezat commented Jun 30, 2025

🚀 This pull request is included in v2.1.7. See Release 2.1.7 for release notes.

@azeezat azeezat deleted the fix/remove-clear-all-when-all-options-are-disabled branch July 1, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Clear All" wrong behavior when all checkbox items are disabled

1 participant