feat: allow setting keyboardShouldPersistTaps#102
Merged
azeezat merged 4 commits intoazeezat:mainfrom Feb 4, 2025
Merged
Conversation
Owner
|
Thank you for contributing to the community! We really appreciate your input. One of the workflow runs failed due to a permission issue in the Github actions file. I have fixed that now. Please kindly rebase your branch and we can release this fix ASAP. Thanks again. |
…-should-persist-taps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There is a potential UX issue when using a searchable dropdown where if the search input is focused and the keyboard is showing you need two taps to select an option, one to dismiss the keyboard and one to actually make the selection.
This issue is fixed by setting
keyboardShouldPersistTaps="always"as a prop on the items' parent scrollable component, this allows tapping the option when the keyboard is open.Fixes #101
Type of change
How Has This Been Tested?
Checklist: