Fix bipartite-color for digraphs with nodes with no outgoing edges#117
Open
prismofeverything wants to merge 1 commit into
Open
Fix bipartite-color for digraphs with nodes with no outgoing edges#117prismofeverything wants to merge 1 commit into
bipartite-color for digraphs with nodes with no outgoing edges#117prismofeverything wants to merge 1 commit into
Conversation
…ming edges, through the addition of a function
jsavyasachi
added a commit
to jsavyasachi/loom
that referenced
this pull request
Jun 21, 2026
bipartite-color colored only successors, so a digraph node with no outgoing edges was unreachable and the result was non-deterministic (often a false nil). Add loom.graph/neighbors (predecessors union successors for digraphs, plain successors for undirected graphs) and color over it. The fix in PR aysylu#117 used predecessors unconditionally, which throws on undirected graphs; guard on directed? so the undirected path is unaffected. Fixes aysylu#118.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An issue came up over in the Ubergraph repository about a failure with
bipartite-colorin the case of digraphs. There is discussion about the problem and solution there. It turns out this function comes from Loom, so I am submitting the fix here.As it seems the code was expecting
successorsto perform as a generalneighborsfunction I wonder if this assumption is being made anywhere else in the code? I know this PR addsneighborsto the core API but IMO this function is fundamental enough to justify it.Open to all thoughts and feedback, thanks!