fix(schema): allow current LogPublishingOptions names#645
fix(schema): allow current LogPublishingOptions names#645yuri1969 wants to merge 1 commit intoawslabs:masterfrom
Conversation
Current `LogPublishingOptions` names feature `_` characters. https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-opensearchservice-domain-logpublishingoption.html
|
Hi @yuri1969 do you have any other evidence that _ is part of those strings? I cannot find anything on the link you've posted |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #645 +/- ##
======================================
Coverage 5.34% 5.34%
======================================
Files 30 30
Lines 19111 19111
======================================
Hits 1022 1022
Misses 18060 18060
Partials 29 29 ☔ View full report in Codecov by Sentry. |
|
@rubenfonseca Currently there are See the copied example snippet below: ...
LogPublishingOptions:
ES_APPLICATION_LOGS:
CloudWatchLogsLogGroupArn: 'arn:aws:...'
Enabled: true
... |
|
Ah got it! The files you've changed are autogenerated from code everytime we do "go generate", so we'll have to find another way to encode this. I'll get back to you. |
Description of changes:
Current
LogPublishingOptionsnames feature_characters.https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-opensearchservice-domain-logpublishingoption.html