Skip to content
This repository was archived by the owner on Oct 17, 2024. It is now read-only.

fix(schema): allow current LogPublishingOptions names#645

Open
yuri1969 wants to merge 1 commit intoawslabs:masterfrom
yuri1969:lpo
Open

fix(schema): allow current LogPublishingOptions names#645
yuri1969 wants to merge 1 commit intoawslabs:masterfrom
yuri1969:lpo

Conversation

@yuri1969
Copy link

@rubenfonseca
Copy link
Contributor

Hi @yuri1969 do you have any other evidence that _ is part of those strings? I cannot find anything on the link you've posted

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (17006b2) 5.34% compared to head (9441407) 5.34%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #645   +/-   ##
======================================
  Coverage    5.34%   5.34%           
======================================
  Files          30      30           
  Lines       19111   19111           
======================================
  Hits         1022    1022           
  Misses      18060   18060           
  Partials       29      29           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yuri1969
Copy link
Author

@rubenfonseca Currently there are SEARCH_SLOW_LOGS, ES_APPLICATION_LOGS, INDEX_SLOW_LOGS, and AUDIT_LOGS names defined. The linked doc also features a link to the OpenSearch CF examples.

See the copied example snippet below:

...
LogPublishingOptions:
      ES_APPLICATION_LOGS:
          CloudWatchLogsLogGroupArn: 'arn:aws:...'
          Enabled: true
...

@rubenfonseca
Copy link
Contributor

Ah got it! The files you've changed are autogenerated from code everytime we do "go generate", so we'll have to find another way to encode this. I'll get back to you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants