fix(deploy-on-aws): check file extension before defusedxml dependency#132
Open
Sagargupta16 wants to merge 2 commits intoawslabs:mainfrom
Open
fix(deploy-on-aws): check file extension before defusedxml dependency#132Sagargupta16 wants to merge 2 commits intoawslabs:mainfrom
Sagargupta16 wants to merge 2 commits intoawslabs:mainfrom
Conversation
Move the defusedxml dependency check after the file extension filter so non-drawio files exit early and silently. Previously, every Edit/Write hook invocation showed a "Missing required dependency" warning even for unrelated files like markdown, JSON, etc. Fixes awslabs#129
Sagargupta16
requested review from
a team,
Copilot,
krokoko,
scottschreckengaust and
theagenticguy
Contributor
There was a problem hiding this comment.
Pull request overview
Reorders validate-drawio.sh so non-.drawio file writes exit immediately, avoiding the noisy defusedxml missing-dependency warning on every Edit|Write hook invocation (fixes #129).
Changes:
- Moves the
defusedxmlavailability check to occur only after the.drawio/.drawio.xmlextension filter passes. - Ensures non-drawio files exit early and silently before any dependency validation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
defusedxmldependency check after the file extension filter invalidate-drawio.shProblem
The
PostToolUsehook onEdit|Writerunsvalidate-drawio.shfor every file write. The script checked for thedefusedxmldependency before checking whether the file was a.drawiofile, causing every non-drawio write (markdown, JSON, etc.) to emit:Fix
Reordered the script to:
defusedxmldependency (only reached for actual drawio files)Related
Fixes #129
Changes
Reordered
validate-drawio.shto check file extension before checking thedefusedxmldependency, so non-drawio file writes exit early and silently.Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.