e2e: update test suites with addon availability, CIDR handling, and conformance improvements#847
Open
tatlat wants to merge 3 commits into
Open
e2e: update test suites with addon availability, CIDR handling, and conformance improvements#847tatlat wants to merge 3 commits into
tatlat wants to merge 3 commits into
Conversation
…ECR auth - Add GetSerialConsoleEndpoint() to support China partition EC2 serial console endpoint format - Refactor Bottlerocket ECR auth to use anonymous ECR Public token for China regions instead of querying private China ECR mirrors (works without AWS credentials) - Update peered node to use partition-aware serial console endpoint
- Add IsAvailable() method to check if addon is offered in current region/partition - Add ErrAddonNotAvailable sentinel error for skipping unavailable addons - Call IsAvailable() in CreateAndWaitForActive() to skip unavailable addons gracefully - Add adot addon support - Fix import alias conflict (e2eerrors vs errors) in addon.go - Update fsxcsidriver, certmanager, pcaissuer with improved error handling - Update fsx_csi_dynamic_provisioning.yaml test data
…onformance improvements - Update suite files to handle addon availability checks gracefully - Add VXLAN/cert-manager webhook port constants to mixed mode tests - Use partition-aware OSProviderList with region parameter - Add CloudVPCCIDR, HybridVPCCIDR, PodCIDR fields to HybridCluster - Add conformance test repo-list.yaml template and dynamic generation - Fix gofumpt: 0644 -> 0o644 octal literal
abhinavmpandey08
previously approved these changes
Mar 29, 2026
tatlat
dismissed
abhinavmpandey08’s stale review
The merge-base changed after approval.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the e2e test suites to use the new addon availability framework, adds VPC CIDR fields to HybridCluster, and improves conformance test setup.
Changes
addon_ec2.go,peered_vpc.go,mixed_mode_test.go,addons_test.go,nodeadm_test.go) to callIsAvailable()and handleErrAddonNotAvailablegracefullyCloudVPCCIDR,HybridVPCCIDR,PodCIDRfields toHybridClusterintest/e2e/peered/cluster.go, populated at lookup time from AWS APIsOSProviderListto accept a region parameter for partition-aware OS selectionrepo-list.yamltemplate with ECR registry mappings and dynamic generation function inconformance_test.goChinaEcrAccountIdand other constants totest/e2e/constants/constants.gotest/e2e/kubernetes/conformance.gowithWithTestRepoListoptionDependencies
Depends on #845 and #846
Testing
make lintpasses with 0 issues