Skip to content

feat: get secrets by versionId or versionStage (#27)#168

Open
ThirdEyeSqueegee wants to merge 5 commits into
aws:masterfrom
ThirdEyeSqueegee:master
Open

feat: get secrets by versionId or versionStage (#27)#168
ThirdEyeSqueegee wants to merge 5 commits into
aws:masterfrom
ThirdEyeSqueegee:master

Conversation

@ThirdEyeSqueegee
Copy link
Copy Markdown
Member

Issue #, if available:
#27

Description of changes:

  • Add optional versionId and versionStage args to GetSecretString and GetSecretBinary to allow retrieving secrets by version ID or version stage

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ThirdEyeSqueegee ThirdEyeSqueegee requested a review from a team as a code owner April 2, 2025 21:39
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 2, 2025

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 73.00%. Comparing base (8110366) to head (e76e350).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...cretsManager.Extensions.Caching/SecretCacheItem.cs 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #168      +/-   ##
==========================================
+ Coverage   72.52%   73.00%   +0.48%     
==========================================
  Files           6        6              
  Lines         222      226       +4     
  Branches       23       24       +1     
==========================================
+ Hits          161      165       +4     
  Misses         52       52              
  Partials        9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/Amazon.SecretsManager.Extensions.Caching/ISecretsManagerCache.cs Outdated
Comment thread src/Amazon.SecretsManager.Extensions.Caching/SecretCacheObject.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants