Skip to content

Log debug info in Browser plugin request handler #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IgorMilavec wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Log debug info in Browser plugin request handler #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53561e3
Log debug info in Browser plugin request handler
IgorMilavec Feb 16, 2026
02f1acb
Log debug info in Browser plugin request handler
IgorMilavec Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/com/amazon/redshift/plugin/BrowserSamlCredentialsProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ public Object apply(List<NameValuePair> nameValuePairs)

return findParameter(SAML_RESPONSE_PARAM_NAME, nameValuePairs);
}
});
}, m_log);
Server server =
new Server(m_listen_port, requestHandler, Duration.ofSeconds(m_idp_response_timeout), m_log);
server.listen();
Expand Down
20 changes: 20 additions & 0 deletions src/main/java/com/amazon/redshift/plugin/httpserver/RequestHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
import org.apache.http.protocol.HttpContext;
import org.apache.http.protocol.HttpRequestHandler;

import com.amazon.redshift.logger.RedshiftLogger;

import java.io.IOException;
import java.util.List;
import java.util.function.Function;
Expand Down Expand Up @@ -61,6 +63,8 @@ public class RequestHandler implements HttpRequestHandler
*/
private boolean is_valid_result = false;

protected RedshiftLogger m_log;

/**
* Constructor.
*
Expand All @@ -73,23 +77,39 @@ public RequestHandler(Function<List<NameValuePair>, Object> requestProcessLogic)
this.m_validRequestHandler = new ValidHttpRequestHandler();
}

public RequestHandler(Function<List<NameValuePair>, Object> requestProcessLogic, RedshiftLogger logger)
{
this(requestProcessLogic);
this.m_log = logger;
}

@Override
public void handle(HttpRequest request, HttpResponse response, HttpContext context)
throws HttpException, IOException
{
if (isRequestValid(request))
{
if (m_log != null) m_log.logInfo("Received generic response");
m_result = m_requestProcessLogic.apply(
URLEncodedUtils.parse(((BasicHttpEntityEnclosingRequest) request).getEntity()));
is_valid_result = true;
m_validRequestHandler.handle(request, response, context);
} else if (isIdcRequestValid(request)) {
if (m_log != null) m_log.logInfo("Received IdC response");
String query = extractQuery(request.toString());
m_result = m_requestProcessLogic.apply(
URLEncodedUtils.parse(query, java.nio.charset.StandardCharsets.UTF_8));
is_valid_result = true;
m_validRequestHandler.handle(request, response, context);
} else {
if (m_log != null)
{
m_log.logError("Received unknown HTTP request");
m_log.logInfo("{0}", request.getRequestLine());
for (Header header : request.getAllHeaders()) {
m_log.logInfo(header.getName() + ": " + header.getValue());
}
}
is_valid_result = false;
m_invalidRequestHandler.handle(request, response, context);
}
Expand Down