Allow node.js to use tls1.0 for db connection#48
Open
benfriebe wants to merge 1 commit intoaws-samples:masterfrom
Open
Allow node.js to use tls1.0 for db connection#48benfriebe wants to merge 1 commit intoaws-samples:masterfrom
benfriebe wants to merge 1 commit intoaws-samples:masterfrom
Conversation
|
I just completed https://github.com/aws-samples/aws-serverless-security-workshop/tree/master/docs/04-ssl-in-transit on 2022-05-14 and can confirm that without this change, you would encounter errors of this form for any function that makes a connection to the Aurora RDS MySQL 5.6 database: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Add node option to lower the minimum tls version to 1.0, which is required when running with a MySQL 5.6 DB.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.