chore: remove pywin32 from expected missing license set#1091
Merged
kavmur merged 1 commit intoaws-deadline:mainlinefrom Apr 6, 2026
Merged
chore: remove pywin32 from expected missing license set#1091kavmur merged 1 commit intoaws-deadline:mainlinefrom
kavmur merged 1 commit intoaws-deadline:mainlinefrom
Conversation
github-actions
Bot
added
the
waiting-on-maintainers
kavmur
force-pushed
the
fix/pywin32-license-detection
branch
from
5bf5faf to
f1c0cc4
Compare
pip-licenses now correctly detects pywin32's license when packages are installed via uv. The _EXPECTED_MISSING_LICENSE set was originally added because older tooling couldn't find pywin32's license metadata. This is no longer the case. Signed-off-by: Kaviraj Murugesan <120754614+kavmur@users.noreply.github.com>
kavmur
force-pushed
the
fix/pywin32-license-detection
branch
from
f1c0cc4 to
efb102e
Compare
kavmur
changed the title
|
diane-hj
approved these changes
Apr 4, 2026
| # Some packages specify their license but do not include it in the repository/package | ||
| # We attribute these manually using _ADDITIONAL_ATTRIBUTIONS | ||
| _EXPECTED_MISSING_LICENSE = {"pywin32"} | ||
| _EXPECTED_MISSING_LICENSE: set[str] = set() |
Contributor
There was a problem hiding this comment.
Not a blocker. If its empty set, can we delete this? 👀
Contributor
Author
There was a problem hiding this comment.
We could, but it's referenced in other places so I kept it as an empty set to minimize changes and preserve the mechanism for future use.
leongdl
approved these changes
Apr 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pip-licenses now correctly detects pywin32's license when packages are installed via uv. The
_EXPECTED_MISSING_LICENSEset was originally added because older tooling couldn't find pywin32's license metadata. This is no longer the case.Changes
pywin32from_EXPECTED_MISSING_LICENSEin the attributions scriptTesting
This fixes the Windows installer build failure where the attributions generation was failing with: