feat: add --name option to bundle gui-submit command#1053
Merged
crowecawcaw merged 7 commits intoaws-deadline:mainlinefrom Apr 13, 2026
Merged
feat: add --name option to bundle gui-submit command#1053crowecawcaw merged 7 commits intoaws-deadline:mainlinefrom
crowecawcaw merged 7 commits intoaws-deadline:mainlinefrom
Conversation
github-actions
Bot
added
the
waiting-on-maintainers
Signed-off-by: Stephen Crowe <6042774+crowecawcaw@users.noreply.github.com>
crowecawcaw
force-pushed
the
feat/gui-submit-name
branch
from
a5e908c to
1115ef7
Compare
baxeaz
previously approved these changes
Mar 17, 2026
2 tasks
mwiebe
reviewed
Mar 18, 2026
karthikbekalp
removed
the
waiting-on-maintainers
… docstring, add tests - Add @overload signatures so required=True returns Dict (not Optional) - Simplify awkward ternary in job_bundle_submitter.py and job_bundle_settings_tab.py - Fix incorrect docstring that referenced wrong return value - Add unit tests for read_yaml_or_json and read_yaml_or_json_object Signed-off-by: Stephen Crowe <6042774+crowecawcaw@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mwiebe
reviewed
Apr 7, 2026
| raise RuntimeError(f"Unexpected file type '{file_type}' in job bundle:\n{bundle_dir}") | ||
|
|
||
|
|
||
| @overload |
Contributor
There was a problem hiding this comment.
Is it possible to set the return type on the main read_yaml_or_json_object function instead of using these two decorators?
|
Signed-off-by: Stephen Crowe <6042774+crowecawcaw@users.noreply.github.com>
crowecawcaw
force-pushed
the
feat/gui-submit-name
branch
from
0ed683b to
dfb9206
Compare
mwiebe
approved these changes
Apr 13, 2026
baxeaz
approved these changes
Apr 13, 2026
|
❌ The last analysis has failed. |
This was referenced Apr 17, 2026
Closed
Closed
This was referenced Apr 17, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #859
What was the problem/requirement? (What/Why)
gui-submit did not support a
--nameparameter.What was the solution? (How)
Add it.
What is the impact of this change?
Allows processes that call the GUI submitter to pre-populate the job name in the GUI. Aligns with the non-GUI submit command.
How was this change tested?
Unit test and manual test.
Was this change documented?
Yes
Does this PR introduce new dependencies?
No
Is this a breaking change?
No
Does this change impact security?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.