Skip to content

fix: improve error message when download directory cannot be created#1034

Merged
crowecawcaw merged 2 commits intoaws-deadline:mainlinefrom
rickrams:fix/improve-download-mkdir-error-message
Apr 13, 2026
Merged

fix: improve error message when download directory cannot be created#1034
crowecawcaw merged 2 commits intoaws-deadline:mainlinefrom
rickrams:fix/improve-download-mkdir-error-message

Conversation

@rickrams
Copy link
Copy Markdown
Contributor

When downloading job output, if the target directory cannot be created (e.g. due to cross-OS path incompatibility like Linux paths on macOS where /home is a synthetic firmlink), the raw OSError was surfaced with a cryptic errno. This wraps the mkdir call with a clear error message that explains the failure and suggests re-running the download to choose a valid local path.

How was this change tested?

See DEVELOPMENT.md for information on running tests.

  • Have you run the unit tests? Yes
  • Have you run the integration tests? No
  • Have you made changes to the download or asset_sync modules? No

Was this change documented?

  • Are relevant docstrings in the code base updated? N/A
  • Has the README.md been updated? N/A

Does this PR introduce new dependencies?

This library is designed to be integrated into third-party applications that have bespoke and customized deployment environments. Adding dependencies will increase the chance of library version conflicts and incompatabilities. Please evaluate the addition of new dependencies. See the Dependencies section of DEVELOPMENT.md for more details.

  • This PR adds one or more new dependency Python packages. I acknowledge I have reviewed the considerations for adding dependencies in DEVELOPMENT.md.
  • This PR does not add any new dependencies.

Is this a breaking change? No

A breaking change is one that modifies a public contract in a way that is not backwards compatible. See the
Public Contracts section
of the DEVELOPMENT.md for more information on the public contracts.

If so, then please describe the changes that users of this package must make to update their scripts, or Python applications.

Does this change impact security? No

  • Does the change need to be threat modeled? For example, does it create or modify files/directories that must only be readable by the process owner?
    • If so, then please label this pull request with the "security" label. We'll work with you to analyze the threats.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions github-actions Bot added the waiting-on-maintainers Waiting on the maintainers to review. label Mar 10, 2026
@rickrams rickrams marked this pull request as ready for review April 1, 2026 19:25
@rickrams rickrams requested a review from a team as a code owner April 1, 2026 19:25
When downloading job output, if the target directory cannot be created
(e.g. due to cross-OS path incompatibility like Linux paths on macOS
where /home is a synthetic firmlink), the raw OSError was surfaced with
a cryptic errno. This wraps the mkdir call with a clear error message
that explains the failure and suggests re-running the download to choose
a valid local path.

Signed-off-by: rickrams <rickrams@users.noreply.github.com>
@mwiebe mwiebe force-pushed the fix/improve-download-mkdir-error-message branch from b387b51 to 7bfdf6c Compare April 9, 2026 22:58
@crowecawcaw crowecawcaw enabled auto-merge (squash) April 13, 2026 16:50
@sonarqubecloud
Copy link
Copy Markdown

@crowecawcaw crowecawcaw merged commit ae9ed20 into aws-deadline:mainline Apr 13, 2026
32 checks passed
This was referenced Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-on-maintainers Waiting on the maintainers to review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants