fix: improve error message when download directory cannot be created#1034
Merged
crowecawcaw merged 2 commits intoaws-deadline:mainlinefrom Apr 13, 2026
Merged
Conversation
leongdl
approved these changes
Apr 9, 2026
jericht
approved these changes
Apr 9, 2026
When downloading job output, if the target directory cannot be created (e.g. due to cross-OS path incompatibility like Linux paths on macOS where /home is a synthetic firmlink), the raw OSError was surfaced with a cryptic errno. This wraps the mkdir call with a clear error message that explains the failure and suggests re-running the download to choose a valid local path. Signed-off-by: rickrams <rickrams@users.noreply.github.com>
b387b51 to
7bfdf6c
Compare
|
This was referenced Apr 17, 2026
Closed
Closed
This was referenced Apr 17, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



When downloading job output, if the target directory cannot be created (e.g. due to cross-OS path incompatibility like Linux paths on macOS where /home is a synthetic firmlink), the raw OSError was surfaced with a cryptic errno. This wraps the mkdir call with a clear error message that explains the failure and suggests re-running the download to choose a valid local path.
How was this change tested?
See DEVELOPMENT.md for information on running tests.
downloadorasset_syncmodules? NoWas this change documented?
Does this PR introduce new dependencies?
This library is designed to be integrated into third-party applications that have bespoke and customized deployment environments. Adding dependencies will increase the chance of library version conflicts and incompatabilities. Please evaluate the addition of new dependencies. See the Dependencies section of DEVELOPMENT.md for more details.
Is this a breaking change? No
A breaking change is one that modifies a public contract in a way that is not backwards compatible. See the
Public Contracts section
of the DEVELOPMENT.md for more information on the public contracts.
If so, then please describe the changes that users of this package must make to update their scripts, or Python applications.
Does this change impact security? No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.