bashttpd: QA

[Kreyren]

Resolved shellcheck where possible left with:

Line 137:
   local code="$1"
         ^-- SC2034: code appears unused. Verify use (or export if used 
externally).

Line 181:
   local dir="$1" tree_vers tree_opts basehref x
                                      ^-- SC2034: basehref appears 
unused. Verify use (or export if used externally).

Line 186:
   read -r x tree_vers x < <(tree --version)
           ^-- SC2034: x appears unused. Verify use (or export if used 
externally).

Line 228:
      [ -r "$URL_PATH" ] && \
                         ^-- SC2015: Note that A && B || C is not 
if-then-else. C may run when A is true.

Line 231:
      [ -x "$URL_PATH" ] && \
                         ^-- SC2015: Note that A && B || C is not 
if-then-else. C may run when A is true.

Line 265:
[ -n "$REQUEST_URI" ] && \
                      ^-- SC2015: Note that A && B || C is not 
if-then-else. C may run when A is true.

Line 284:
source "${BASH_SOURCE[0]%/*}"/bashttpd.conf
       ^-- SC1090: Can't follow non-constant source. Use a directive to 
specify location.

Signed-off-by: Jacob Hrbek kreyren@rixotstudio.cz

[AdamDanischewski]

Line 186 is to trap the second field in tree_vers, I do the same thing in my reworked file server only version that streams multimedia: https://github.com/victrixsoft/bashbro/