Skip to content

Updated files to be in sync with the documentation on Gitbook#1

Open
Frituurpanda wants to merge 4 commits into
masterfrom
sync-with-gitbook-documentation
Open

Updated files to be in sync with the documentation on Gitbook#1
Frituurpanda wants to merge 4 commits into
masterfrom
sync-with-gitbook-documentation

Conversation

@Frituurpanda
Copy link
Copy Markdown

Maarten approved the documentation on GitBook. This change will update our reference repository with the changes on GitBook.

Next up is adding this as the default repo to GFC!

@Frituurpanda Frituurpanda requested a review from keerts February 14, 2020 10:45
Comment thread README.md

You can install Git for Confluence by using the Universal Plugin Manager inside
Confluence, or by visiting the [Git for Confluence marketplace entry][1]
Confluence, or by visiting the
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added the link directly.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dat zie ik, maar waarom? Ik leer altijd graag mee.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Omdat een gebruiker nu direct op de link kan klikken ipv naar de footnotes moet scrollen, daar een link moet selecteren en in zijn browser moet plakken.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Die link wordt gewoon inline gerenderd, daar verandert niets aan toch?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eerst stonden de links als footnote, nu staan de links inline wat mij beter leek dan ze als footnote toevoegen. De footnotes zijn in de laatste commit ook verwijderd. Het doel hier is het voor een gebruiker zo simpel mogelijk maken om naar de docu te gaan. Als een gebruiker eerst nog naar de footnotes moet zoeken is dat weer een extra stap die ik graag wil voorkomen.

Comment thread README.md
If you want to learn how to configure Git for Confluence or use the Git for
Confluence macro's, please refer tot the [Git for Confluence documentation][2]
Confluence macro's, please refer tot the
[Git for Confluence documentation](https://avisi-apps.gitbook.io/git-for-confluence/).
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idem

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. Moved the link from the bottom to use it directly here.

Comment thread README.md Outdated
Comment thread README.md Outdated
Several images in several formats are available in the formats/markdown folder.
An images will simply be show as an image when included on a Cofluence page by
using the view-git-file macro.
An images will simply be show as an image when included on a Confluence page by
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An image or Images

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only fixed the misspelled Confluence there. Will fix that too!

Comment thread README.md
in the formats directory:
```bash
.
├── README.md
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dit is wel onderhoudsgevoelig

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zeker, naar mijn mening worth it omdat we de repo hopelijk niet vaak gaan updaten.

Comment thread formats/code/index.html
<h2>Introduction to the Git Reference</h2>
<div class="block">
<p>
This is the Git reference site. It is meant to be a quick
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dit kan dan weer verwarrend werken

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wat is de reden voor het toevoegen van dit bestand? Is dit een voorbeeld voor code markup?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inderdaad, iets van een blok code markup. Deze is toevallig free to use zonder daar een clause voor toe te moeten voegen en ziet er wel mooi uit. Denk je dat het beter is anders zelf een blokje te schrijven?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Het is veel beter als we (of desnoods marketing) hier een mooie pagina voor maakt. De vraag is ook of html de beste optie is, of code. Wie is er aan het evalueren en wordt hier blij van? Is het beter om (ook) clojure / java / etc bestanden toe te voegen?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prima, zal ik deze sectie dan verwijderen?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of veranderen door inhoud die over Git for Confluence gaat, of een compleet random html bestand, of beter iets van Java code ofzo?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll look for something!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants