Skip to content

Conversation

@rishirajrandive
Copy link

@rishirajrandive rishirajrandive commented Oct 21, 2017

Any great library for making fancy FABs/ FAB menu could be used with AHBottomNavigation
The changes here:

  1. Make manageFloatingActionButtonBehavior methods to generic.
  2. Update DemoActivity to accommodate the changed methods. Where only one more argument is added to manageFloatingActionButtonBehavior() method, the argument is 'factor' which is used for positioning the Y of FAB or FAB menu.

…ake relevant methods to generic. Update demo to accommodate the changed methods
@Rainer-Lang
Copy link

@rishirajrandive Clans FAB isn't maintained anymore. There are other alternative libs which are very good maintained. IMHO even in the demo there shouldn't be an old lib.

@rishirajrandive
Copy link
Author

Thanks! @Rainer-Lang, it makes sense.
I was not aware of other libraries like Clans FAB and I used Clans FAB in my project along with AhBottomNavigation, so I ended up making this change.

@Rainer-Lang
Copy link

@rishirajrandive It's ok. Have a look here: https://github.com/jahirfiquitiva/FABsMenu

@rishirajrandive
Copy link
Author

@Rainer-Lang thank you for the library, will this work with ahbottomnavigation?

@Rainer-Lang
Copy link

@rishirajrandive I really don't know. Sorry. But if you test it - please give feedback here or even better change your PR. :-)

@rishirajrandive
Copy link
Author

@Rainer-Lang I checked for the suggested library, changes in the pull request work well with it. Changes in pull request are generic and not dependent on any library.

@rishirajrandive rishirajrandive changed the title Add support for clan's FloatingActionButton library Add support for any FloatingActionButton library Oct 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants