Rename module to SwiftBigInt to fix module stability compilation#131
Open
jlalvarez18 wants to merge 2 commits intoattaswift:masterfrom
Open
Rename module to SwiftBigInt to fix module stability compilation#131jlalvarez18 wants to merge 2 commits intoattaswift:masterfrom
jlalvarez18 wants to merge 2 commits intoattaswift:masterfrom
Conversation
Fixes Swift compiler error when building with BUILD_LIBRARY_FOR_DISTRIBUTION=YES: "'BigInt' is not a member type of struct 'BigInt.BigInt'" Changes: - Product/module name: BigInt → SwiftBigInt - Package name: Remains "BigInt" (repository name) - Type names: UNCHANGED (BigInt/BigUInt still work) Migration: Only import statements change from `import BigInt` to `import SwiftBigInt` Follows Swift naming conventions (SwiftNIO, SwiftLog, SwiftCrypto)
Collaborator
|
Thank you for looking into this, I think it would be better to wait for Swift to implement module selectors swiftlang/swift#34556 which will most likely land in the next Swift release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename module to SwiftBigInt to fix module stability compilation
BREAKING CHANGE: Module name changed from BigInt to SwiftBigInt
Problem
The module name "BigInt" conflicted with the struct name "public struct BigInt",
causing Swift compiler errors when building with BUILD_LIBRARY_FOR_DISTRIBUTION=YES
(required for XCFramework distribution and module stability):
Solution
Renamed the module to "SwiftBigInt" following Swift community conventions
(similar to SwiftNIO, SwiftLog, SwiftCrypto).
Changes
Migration for Consumers
Only import statements need to change:
Benefits
Files Modified
Version
Requires major version bump: 5.4.0 → 6.0.0
Fixes module interface verification bug when building with library evolution enabled.